ThirdPerson Templates v2.5.4

[Invector]

Shooter 2.5.4 Hotfix Update 19/10/2020

- Add 'SetSpawnPoint(transform) method in the vGameController component
- Add more events to TriggerGeneric Action
- Add Secondary Ammo display
- Add Simple trigger with input
- Add optional 'SkipEmptySlots' for the Inventory when switching between slots
- Add LockOn 'LockSpeed' float variable for the transition speed
- Add method UseAnimatorMove(bool) to use the Controller with Cutscenes (ex: call when using Timeline)
- Improved Joystick Mouse Input on Inventory (now it works only when using inventory)
- Improved StepOffset detection
- Improved DeadBehavior method to use AnimatorTag instead of IsName (this allows multiple death animations to be used)
- Fix Simple trigger other detection
- Fix Roll and Attack triggering in the same time
- Fix TriggerGenericAction enter and exit events being called more than once
- Fix Stack Overflow in the Shooter Equipment
- Fix Nan error when openning the Inventory with Time.Scale 0 and using a Controller with RootMotion enabled
- Fix HealthRecovery not working properly
- Fix Sprinting while attacking consume extra stamina
- Fix MoveSet not getting back to default when holstering a weapon when 'UseDefaultMovesetWhileAiming' is false
- Fix OnActiveRagdoll(vDamage) event being called all the time when falling from height places

MeleeCombat 2.5.4 Hotfix Update 19/10/2020

- Add 'SetSpawnPoint(transform) method in the vGameController component
- Add more events to TriggerGeneric Action
- Add Simple trigger with input
- Add optional 'SkipEmptySlots' for the Inventory when switching between slots
- Add LockOn 'LockSpeed' float variable for the transition speed
- Add method UseAnimatorMove(bool) to use the Controller with Cutscenes (ex: call when using Timeline)
- Improved Joystick Mouse Input on Inventory (now it works only when using inventory)
- Improved StepOffset detection
- Improved DeadBehavior method to use AnimatorTag instead of IsName (this allows multiple death animations to be used)
- Fix Simple trigger other detection
- Fix Roll and Attack triggering in the same time
- Fix TriggerGenericAction enter and exit events being called more than once
- Fix Nan error when openning the Inventory with Time.Scale 0 and using a Controller with RootMotion enabled
- Fix HealthRecovery not working properly
- Fix Sprinting while attacking consume extra stamina
- Fix MoveSet not getting back to default when holstering a weapon when 'UseDefaultMovesetWhileAiming' is false
- Fix OnActiveRagdoll(vDamage) event being called all the time when falling from height places

Basic Locomotion 2.5.4 Hotfix Update 19/10/2020

- Add 'SetSpawnPoint(transform) method in the vGameController component
- Add more events to TriggerGeneric Action
- Add Simple trigger with input
- Add method UseAnimatorMove(bool) to use the Controller with Cutscenes (ex: call when using Timeline)
- Improved StepOffset detection
- Improved DeadBehavior method to use AnimatorTag instead of IsName (this allows multiple death animations to be used)
- Fix Simple trigger other detection
- Fix TriggerGenericAction enter and exit events being called more than once
- Fix HealthRecovery not working properly
- Fix OnActiveRagdoll(vDamage) event being called all the time when falling from height places

[tsuyoiraion]

- Improved Joystick Mouse Input on Inventory (now it works only when using inventory)

I actually specifically call to and use the mouse cursor outside of the inventory in a lot of instances, is this new addition going to mess with that?

Also have you looked into the inventory enum values resetting when adding a new enum? I don't see that in the list above and it's been quiet a while.

[Invector]

Oct 20, 2020 15:56:25 GMT tsuyoiraion said:

- Improved Joystick Mouse Input on Inventory (now it works only when using inventory)

I actually specifically call to and use the mouse cursor outside of the inventory in a lot of instances, is this new addition going to mess with that?

Also have you looked into the inventory enum values resetting when adding a new enum? I don't see that in the list above and it's been quiet a while.

These improvements are specifically for when using the joystick that simulates a mouse behavior, it shouldn't interferer with the mouse.

About the enum values resetting, as we talk via email we didn't manage to reproduce the issues you described, as I told you what could be related is the fact that you're using an older version of the Editor.

We ship the package using Unity 2018.4.23 released on 19 May, 2020
and you're using Unity 2018.4.5 released on 26 Jul, 2019

[tsuyoiraion]

Oct 20, 2020 17:58:50 GMT Invector said:

Oct 20, 2020 15:56:25 GMT tsuyoiraion said:

- Improved Joystick Mouse Input on Inventory (now it works only when using inventory)

I actually specifically call to and use the mouse cursor outside of the inventory in a lot of instances, is this new addition going to mess with that?

Also have you looked into the inventory enum values resetting when adding a new enum? I don't see that in the list above and it's been quiet a while.

These improvements are specifically for when using the joystick that simulates a mouse behavior, it shouldn't interferer with the mouse.

About the enum values resetting, as we talk via email we didn't manage to reproduce the issues you described, as I told you what could be related is the fact that you're using an older version of the Editor.

We ship the package using Unity 2018.4.23 released on 19 May, 2020
and you're using Unity 2018.4.5 released on 26 Jul, 2019

Ah ok good :P yea i use the mouse cursor that the inventory uses, outside of the inventory for my other menus.

Actually your last email showed you were able to reproduce the issue in the video you sent me and you stated you see the issue.

So my response was alright now that you can reproduce the issue and see it, can you look into what is causing the issue due to unity version.

It doesn't matter what version you shipped the asset from, i'm using it in a few unity versions later, if there's an issue with the enums a few versions later, that's something you need to attend to.

Unless you specifically state "our asset does not work properly in these versions" and state the versions or "our asset does not work properly past this unity version".

Here's a refresher on our last convo about the enum issue:

You: 
That's odd, indeed it re-draw the enum and it loses the name but the order is still the same, Defense is the ItemType number 7 so it's working as it should be.

It's probably a bug from the editor version that you're using it, which is older than the version we ship the package to the AssetStore 2018.4.23f1

Me:
Well i'm using a newer version (i.e 2018.4.5) which is the minimum unity version unity allows for asset store packages, thus the version you shipped the current asset version from is older than the unity version i am using.

However yes as you can see the enum does in fact break, even if the order stays the same, it still breaks the items which means the user has to go in and re-work anything linked to that specific enum usage (i.e shield, etc.), which is not good.

So now that you can see the issue, hopefully you can fix it because i cannot integrate a custom package into yours if it breaks other features.

[uberwiggett]

both store pages list the minimum as higher than 2018.4.5 ( 2018.4.23 is higher than 2018.4.5, it should probably say 2018.4.05 to make it clearer) :P I have used it in earlier versions and I've not seen this issue either, has it only been happening since 2.53?

[Invector]

tsuyoiraion I thought that by keeping the same number it would still work but I just tested here and indeed it breaks the item, we will check this

[tsuyoiraion]

Oct 21, 2020 8:18:20 GMT uberwiggett said:

both store pages list the minimum as higher than 2018.4.5 :P I have used it in earlier versions and I've not seen this issue either, has it only been happening since 2.53?

Actually it states "2018.4.23 or higher", so that's what the Invector team has been testing in, although minimum initial submission for the asset store is 2018.4.5.

Oct 21, 2020 12:33:44 GMT Invector said:

tsuyoiraion I thought that by keeping the same number it would still work but I just tested here and indeed it breaks the item, we will check this

Awesome, thanks 

[Invector]

tsuyoiraion We just figure it out what's the problem with the ItemEnum.

It is working correctly but the problem is, during the development of the Crafting Add-on the ItemType CraftingMaterials was included on the ItemListData before the Defense (for some mysterious reason), and when you refresh the ItemListData by adding or removing something, it will try to locate the Crafting ItemEnum and if you don't have it in your project it will remove and make the Defense enum 6 instead of 7, that's why it's losing reference.

All you have to do is remove the ItemType CraftingMaterials from the ItemListData if you don't use it, or removing and add again (so it can be last in the list) if you have the Crafting add-on in your project.

You only need to set the ItemType again once (next update will have this updated)

[tsuyoiraion]

Oct 21, 2020 18:07:04 GMT Invector said:

tsuyoiraion We just figure it out what's the problem with the ItemEnum.

It is working correctly but the problem is, during the development of the Crafting Add-on the ItemType CraftingMaterials was included on the ItemListData before the Defense (for some mysterious reason), and when you refresh the ItemListData by adding or removing something, it will try to locate the Crafting ItemEnum and if you don't have it in your project it will remove and make the Defense enum 6 instead of 7, that's why it's losing reference.

All you have to do is remove the ItemType CraftingMaterials from the ItemListData if you don't use it, or removing and add again (so it can be last in the list) if you have the Crafting add-on in your project.

You only need to set the ItemType again once (next update will have this updated)

Interesting, ah those little bugs :P well glad you found the issue, i'll wait for that fix to be pushed live before submitting my custom asset integration 

[tsuyoiraion]

I seem to have found another bug and i believe i mentioned this a while back but never found the exact cause, now i know the exact cause hehe

The issue is the inventory and items being destroyed when using an item or switching items inside or outside of the inventory, this happens after you save and load the players inventory after respawn. (Using built in Invector inventory save/load calls)

Steps to reproduce:

1. Start game
2. Save inventory
3. Die (destroy body, respawn)
4. Load inventory on respawn
5. Either try to use an item or gather new items, try to use them
6. Loaded items & newly collected items disappear

Can you please look into this? Thanks!

[tsuyoiraion]

So after A LOT of testing, the inventory issue seems to reside in how the item manager works and some sort of delay that occurs when it starts.

Thus in order for inventory to work correctly, you have to buff/wait a decent amount of time before loading the inventory, no matter if it's the first game launch or re-spawning after dying.

While this isn't a huge issue, if you don't actually hide the player or do a particle effect to show the player respawn, you'll end up with inventory items just popping into place due to the necessary delay before load.

So probably something to consider tinkering with and seeing if that delay is really necessary

Lastly, i haven't seen an update pushed with the enum fix you mentioned above, when do you plan on pushing that?

Thanks!