Issue with Weapon Holder (shooter/Melee)

[jgiroux]

using Unity v5.6

using Basic 2.2.4
melee 2.2.4
shooter 1.1.4

The issue I have been having is an error every once in awhile, usually associated with swapping from melee to shooter.

I followed the tutorials.
1) empty game object in bone of PC
2) added weapon model only
3) added an empty transform for weapon holder (didnt think this would be an issue)
4) added the Weapon Holder script to each holder.
5) set the holder object to the empty transform
6) added the weapon object (model only) to weapon object
7) set EquipPoint to "RightArm"
8) set Item ID to item ID of weapon (currently only using invector template stock)

9) added the WeaponHolder manager by selecting PC, going to invector menu and under components selecting weapon holder manager(player only)

setting tag of both holder and weapon model to *weapon* and layer to *ignore raycast*

however at some point in the game while swapping out weapons, I run into this:






more detailed error below, but by any chance anyone can help me at least track down the issue? or where I should be looking for an error?

i did make sure my equip points match their names. Im just not sure where the issue lies.

thanks for any help! 

NullReferenceException: Object reference not set to an instance of an object
Invector.ItemManager.vWeaponHolderManager+<EquipWeapon>c__AnonStorey3.<>m__0 (.vWeaponHolder h) (at Assets/Invector-3rdPersonController/ItemManager/Scripts/vWeaponHolderManager.cs:65)
System.Collections.Generic.List`1[vWeaponHolder].GetIndex (Int32 startIndex, Int32 count, System.Predicate`1 match) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Collections.Generic/List.cs:313)
System.Collections.Generic.List`1[vWeaponHolder].Find (System.Predicate`1 match) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Collections.Generic/List.cs:216)
Invector.ItemManager.vWeaponHolderManager.EquipWeapon (Invector.ItemManager.vEquipArea equipArea, Invector.ItemManager.vItem item) (at Assets/Invector-3rdPersonController/ItemManager/Scripts/vWeaponHolderManager.cs:64)
UnityEngine.Events.InvokableCall`2[Invector.ItemManager.vEquipArea,Invector.ItemManager.vItem].Invoke (System.Object[] args) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent.cs:221)
UnityEngine.Events.InvokableCallList.Invoke (System.Object[] parameters) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent.cs:637)
UnityEngine.Events.UnityEventBase.Invoke (System.Object[] parameters) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent.cs:773)
UnityEngine.Events.UnityEvent`2[T0,T1].Invoke (.T0 arg0, .T1 arg1) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent_2.cs:53)
Invector.ItemManager.vItemManager.EquipItem (Invector.ItemManager.vEquipArea equipArea, Invector.ItemManager.vItem item) (at Assets/Invector-3rdPersonController/ItemManager/Scripts/vItemManager.cs:586)
UnityEngine.Events.InvokableCall`2[Invector.ItemManager.vEquipArea,Invector.ItemManager.vItem].Invoke (System.Object[] args) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent.cs:221)
UnityEngine.Events.InvokableCallList.Invoke (System.Object[] parameters) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent.cs:637)
UnityEngine.Events.UnityEventBase.Invoke (System.Object[] parameters) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent.cs:773)
UnityEngine.Events.UnityEvent`2[T0,T1].Invoke (.T0 arg0, .T1 arg1) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent_2.cs:53)
Invector.ItemManager.vInventory.EquipItem (Invector.ItemManager.vEquipArea equipArea, Invector.ItemManager.vItem item) (at Assets/Invector-3rdPersonController/ItemManager/Scripts/vInventory.cs:359)
UnityEngine.Events.InvokableCall`2[Invector.ItemManager.vEquipArea,Invector.ItemManager.vItem].Invoke (System.Object[] args) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent.cs:221)
UnityEngine.Events.InvokableCallList.Invoke (System.Object[] parameters) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent.cs:637)
UnityEngine.Events.UnityEventBase.Invoke (System.Object[] parameters) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent.cs:773)
UnityEngine.Events.UnityEvent`2[T0,T1].Invoke (.T0 arg0, .T1 arg1) (at C:/buildslave/unity/build/Runtime/Export/UnityEvent_2.cs:53)
Invector.ItemManager.vEquipArea.OnPickItem (Invector.ItemManager.vItemSlot slot) (at Assets/Invector-3rdPersonController/ItemManager/Scripts/vEquipArea.cs:193)
Invector.ItemManager.vItemWindow.OnSubmit (Invector.ItemManager.vItemSlot slot) (at Assets/Invector-3rdPersonController/ItemManager/Scripts/vItemWindow.cs:127)
Invector.ItemManager.vItemSlot.OnSubmit (UnityEngine.EventSystems.BaseEventData eventData) (at Assets/Invector-3rdPersonController/ItemManager/Scripts/vItemSlot.cs:115)
UnityEngine.EventSystems.ExecuteEvents.Execute (ISubmitHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at C:/buildslave/unity/build/Extensions/guisystem/UnityEngine.UI/EventSystem/ExecuteEvents.cs:127)
UnityEngine.EventSystems.ExecuteEvents.Execute[ISubmitHandler] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.EventFunction`1 functor) (at C:/buildslave/unity/build/Extensions/guisystem/UnityEngine.UI/EventSystem/ExecuteEvents.cs:261)
UnityEngine.EventSystems.EventSystem:Update()

[g4bri3l]

Hi, I have similar problem.

Only difference is with holder (I used a gun holster for the holder)
Followed all steps like you. Only th upper slot seems to work. I start the game with a handgun and andgun ammo as initial inventory equipment.

Tryed with the demoscene invector with inventory and nothing changed.

Anyone can Help us?

Thanks in advice for the response.

Gabriele

[rocco]

hey .. I use the integration of Sickscore for inventor Pro and do not have this problem .. have a look at his script to equip ..

[g4bri3l]

Now I'm trying to reimport the asset. I just see that in the demoscene invector_shoter_only with inventory the handgun holder inside the VBOT_RightUpLeg is set in bodypart layer instead Ignore raycast as specified in the tutorial.

Tryed to change to ignore raycast layer but nothing changed. When select the upper slot (slot with index 0) it's all instead whit other 3 equip slot i got jgiroux' same error.

In debug:


//Check All Holders to Show

               for (int i = 0; i < slotsInArea.Count; i++)

               {

                   if (slotsInArea[i].item != null)

                   {

                       var holder = holderAreas[equipArea.equipPointName].Find(h => slotsInArea[i].item.id == h.itemID &&

                       (equipArea.currentEquipedItem != item && equipArea.currentEquipedItem != slotsInArea[i].item && equipArea.currentEquipedItem.id != item.id));



                       if (holder)

                       {

                           holder.SetActiveHolder(true);

                           holder.SetActiveWeapon(true);                          

                       }

                   }

               }

With i=0 the equipArea.currentEquipedItem contains the weapon  I have selected (handgun).
With i>0 the equipArea.currentEquipedItem is null.

Hope this is usefull to help who can help us

Thanks again and sorry for my english.

[g4bri3l]

Dec 13, 2017 21:45:05 GMT g4bri3l said:

Now I'm trying to reimport the asset. I just see that in the demoscene invector_shoter_only with inventory the handgun holder inside the VBOT_RightUpLeg is set in bodypart layer instead Ignore raycast as specified in the tutorial.

Tryed to change to ignore raycast layer but nothing changed. When select the upper slot (slot with index 0) it's all instead whit other 3 equip slot i got jgiroux' same error.

In debug:


//Check All Holders to Show

               for (int i = 0; i < slotsInArea.Count; i++)

               {

                   if (slotsInArea[i].item != null)

                   {

                       var holder = holderAreas[equipArea.equipPointName].Find(h => slotsInArea[i].item.id == h.itemID &&

                       (equipArea.currentEquipedItem != item && equipArea.currentEquipedItem != slotsInArea[i].item && equipArea.currentEquipedItem.id != item.id));



                       if (holder)

                       {

                           holder.SetActiveHolder(true);

                           holder.SetActiveWeapon(true);                          

                       }

                   }

               }

With i=0 the equipArea.currentEquipedItem contains the weapon  I have selected (handgun).
With i>0 the equipArea.currentEquipedItem is null.

Hope this is usefull to help who can help us

Thanks again and sorry for my english.

Ok I found a partially solution. After 2 hours spent understanding why  "equipArea.currentEquipedItem" was null if the selected slot !=0, I resolve in this way:

public void EquipWeapon(vEquipArea equipArea, vItem item)

       {          

           var slotsInArea = equipArea.ValidSlots;

           if (slotsInArea != null && slotsInArea.Count > 0 && holderAreas.ContainsKey(equipArea.equipPointName))

           {

               //Check All Holders to Show

               for (int i = 0; i < slotsInArea.Count; i++)

               {

                   if (slotsInArea[i].item != null)

                   {

                       if (equipArea.currentEquipedItem != null) //BUGFIX
                       {

                           var holder = holderAreas[equipArea.equipPointName].Find(h => slotsInArea[i].item.id == h.itemID &&

                                            (equipArea.currentEquipedItem != item &&
     equipArea.currentEquipedItem != slotsInArea[i].item &&
     equipArea.currentEquipedItem.id != item.id));



                           if (holder)

                           {

                               holder.SetActiveHolder(true);

                               holder.SetActiveWeapon(true);                          

                           }

                       }

                       else //BUGFIX
                       {

                           var holder = holderAreas[equipArea.equipPointName].Find(h => slotsInArea[i].item.id == h.itemID);



                           if (holder)

                           {

                               holder.SetActiveHolder(true);

                               holder.SetActiveWeapon(true);                          

                           }

                       }

                   }

               }

               //Check Current Item to Equip with time

               if (equipArea.currentEquipedItem != null)

               {

                   var holder = holderAreas[equipArea.equipPointName].Find(h => h.itemID == equipArea.currentEquipedItem.id);

                   if (holder)

                   {

                       holder.equipDelayTime = equipArea.currentEquipedItem.equipDelayTime;

                       // Unhide Holder and hide Equiped weapon

                       StartCoroutine(EquipRoutine(holder, true, false, (itemManager.inventory != null &&
 itemManager.inventory.isOpen)));

                   }

               }

           }    

       }



This fix the NullPointerException and allow weapon holder to show. The only difference is if slot != 0 the weapon associated don't auto equip. But is sufficient to press associated button (2,3,4) to equip the weapon.

Hope someone can help me to fix this problem, but meanwhile this fix seems a good compromise.